ODF actor implemented with Ray Tracing #869
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ODF with texture coeffs
guaje
requested changes
Sep 5, 2024
There was a problem hiding this comment.
Hello @tvcastillod, here are some minor comments on some of these files.
guaje
requested changes
Sep 13, 2024
There was a problem hiding this comment.
Hello @tvcastillod!
Overall great work putting up together such a needed actor.
In addition to the changes outlined below, I suggest moving the content of rt_odfs to ray_tracing/odf.
skoudoro
reviewed
Sep 24, 2024
There was a problem hiding this comment.
exciting, thank you for this work @tvcastillod !
First, can you fix the issues from code format CI's and build doc CI's
then, see my first initial comments below.
Question: Can you explain a bit how did you get all this eval_sh_*?
| @@ -4019,3 +4020,73 @@ def uncertainty_cone( | |||
| angles = main_dir_uncertainty(evals, evecs, signal, sigma, b_matrix) | |||
|
|
|||
| return double_cone(centers, evecs, angles, colors, scales, opacity) | |||
|
|
|||
|
|
|||
| @warn_on_args_to_kwargs() | |||
There was a problem hiding this comment.
not needed since this is a new function
| Type of basis (descoteaux, tournier) | ||
| 'descoteaux' for the default ``descoteaux07`` DYPY basis. | ||
| 'tournier' for the default ``tournier07` DYPY basis. | ||
| scales : float or ndarray (N, ) |
| 'tournier' for the default ``tournier07` DYPY basis. | ||
| scales : float or ndarray (N, ) | ||
| ODFs size. | ||
| opacity : float |
| ---------- | ||
| data: ndarray | ||
| 2D array | ||
| axis: int |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to create a new odf actor defined with raymarching based on the paper Ray Tracing Spherical Harmonics Glyphs . Work is still in progress.
A visual comparison with the current implementation of fury using polygons
An example is provided showing that it supports displaying multiple glyphs, and with different SH degree.
